sonarqube_qualitygate should populate the conditions property

jdamata / terraform-provider-sonarqube

Terraform provider for managing Sonarqube configuration

GNU General Public License v3.0

62 stars 54 forks source link

sonarqube_qualitygate should populate the conditions property #157

Closed freeranger closed 1 year ago

freeranger commented 1 year ago

Fixes https://github.com/jdamata/terraform-provider-sonarqube/issues/156

If you apply the fix but don't update the test then:

Running against SonarQube 9.8 and below there will be no change and the tests will pass
Running against SonarQube 9.9 and above, the relevant test will fail

Updating the test will allow it to pass successfully with either version

jdamata commented 1 year ago

After reading https://github.com/jdamata/terraform-provider-sonarqube/issues/154#issuecomment-1525546478 I think we are either going in 2 directions.

Delete the auto populated conditions
Refactor the conditions into the gate resource and delete/replace conditions that are not specified.

Populating conditions into state that are not defined in TF isn't something im crazy about

freeranger commented 1 year ago

Agreed that this is probably redundant if we go with #154 - I submitted this because it looks like the intent was to populate the conditions but that it was failing because the body had already been read...though that didn't matter since pre-9.9 there was nothing to populate anyway.

So fixing an apparent bug but likely surplus to requirements in the near future

jdamata commented 1 year ago

can this be closed since https://github.com/jdamata/terraform-provider-sonarqube/pull/163 will be merged

freeranger commented 1 year ago

Closing in favour of #163