jdamcd / android-crop

Android library project for cropping images
4.54k stars 1.08k forks source link

Crash disabling permission #290

Open gelbertgel opened 5 years ago

gelbertgel commented 5 years ago

CropImageActivity page is crashing, if external storage permission is disabled. Please fix this error.

Device info

Devices: Samsung Note 8 Android version: = 8.0 Library version: 1.0.1

Steps to reproduce

Crash log

2018-11-11 23:09:43.462 12983-12983/? 
    java.lang.RuntimeException: Unable to start activity ComponentInfo{com.soundcloud.android.crop.CropImageActivity}: java.lang.SecurityException: Permission Denial: reading com.android.providers.media.MediaProvider uri content://media/external/images/media/105 from pid=12983, uid=10207 requires android.permission.READ_EXTERNAL_STORAGE, or grantUriPermission()
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2957)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3032)
        at android.app.ActivityThread.-wrap11(Unknown Source:0)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1696)
        at android.os.Handler.dispatchMessage(Handler.java:105)
        at android.os.Looper.loop(Looper.java:164)
        at android.app.ActivityThread.main(ActivityThread.java:6940)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:327)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1374)
        at android.os.Parcel.readException(Parcel.java:1959)
        at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:183)
        at android.database.DatabaseUtils.readExceptionWithFileNotFoundExceptionFromParcel(DatabaseUtils.java:146)
        at android.content.ContentProviderProxy.openTypedAssetFile(ContentProviderNative.java:698)
        at android.content.ContentResolver.openTypedAssetFileDescriptor(ContentResolver.java:1416)
        at android.content.ContentResolver.openAssetFileDescriptor(ContentResolver.java:1253)
        at android.content.ContentResolver.openInputStream(ContentResolver.java:973)
        at com.soundcloud.android.crop.CropImageActivity.calculateBitmapSampleSize(CropImageActivity.java:152)
        at com.soundcloud.android.crop.CropImageActivity.setupFromIntent(CropImageActivity.java:130)
        at com.soundcloud.android.crop.CropImageActivity.onCreate(CropImageActivity.java:79)
        at android.app.Activity.performCreate(Activity.java:7183)
        at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1220)
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2910)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3032) 
        at android.app.ActivityThread.-wrap11(Unknown Source:0) 
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1696) 
        at android.os.Handler.dispatchMessage(Handler.java:105) 
        at android.os.Looper.loop(Looper.java:164) 
        at android.app.ActivityThread.main(ActivityThread.java:6940) 
        at java.lang.reflect.Method.invoke(Native Method) 
        at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:327) 
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1374) 
INF4M0US commented 5 years ago

This is happening mostly on Android 7

gelbertgel commented 5 years ago

It is happening all over 6.0 SDK version.