search

jdammers / jumeg

MEG Data Analysis at FZJ
BSD 3-Clause "New" or "Revised" License
10 stars 26 forks source link

Multiple directories #201

Closed pravsripad closed 5 years ago

pravsripad commented 5 years ago

There are some similar directories which can lead to some confusion,

jumeg/jumeg/ioutils /jumeg/jumeg/tools

jumeg/jumeg/template/ jumeg/jumeg/templates/

Can they be renamed to combined?

@fboers @jdammers

jdammers commented 5 years ago

From my point of view we combine it, but I think it was written by @fboers. @fboers can you comment on this, please?

fboers commented 5 years ago

jumeg/jumeg/ioutils -> io utility modules helper functions e.g. for the gui and scripts

jumeg/jumeg/tools -> scripts for merging meg and eeg data, export to fif

jumeg/jumeg/template/ -> source code for template modules

jumeg/jumeg/templates/ -> the templates for epocher and experiments settings

templates is like settings/config/templates/data:

templates can be moved to jumeg/data/templates

dirs with source codes: ioutils tools template

if you want to make it more cleaner/clearer put them in a subfolder like

jumeg/base/ioutils jumeg/base/template in base put , too

tools should stay or put them under pipeline/tools

please delete jumeg/jumeg_merge_meeg.py from jumeg

If this makes more sense I can do this soon in the next version update

vg Frank

On 17.04.19 11:55, Praveen Sripad wrote:

There are some similar directories which can lead to some confusion,

jumeg/jumeg/ioutils /jumeg/jumeg/tools

jumeg/jumeg/template/ jumeg/jumeg/templates/

Can they be renamed to combined?

@fboershttps://github.com/fboers @jdammershttps://github.com/jdammers

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/jdammers/jumeg/issues/201, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGy3qAdG_Gk853Q2i15yRfcnaU3cwfcAks5vhu-jgaJpZM4c0qQr.

-- Frank Boers Institute of Neuroscience and Medicine - 4 Medical Imaging Physics Forschungszentrum Juelich GmbH 52425 Juelich phone: +49 - (0)2461-61-6005 fax : +49 - (0)2461-61-2820 email: f.boers@fz-juelich.demailto:f.boers@fz-juelich.de http://www.fz-juelich.de/inm/inm-4/DE/Forschung/MEG-Physik/_node.html

Forschungszentrum Juelich GmbH 52425 Juelich Sitz der Gesellschaft: Juelich Eingetragen im Handelsregister des Amtsgerichts Dueren Nr. HR B 3498 Vorsitzender des Aufsichtsrats: MinDir Dr. Karl Eugen Huthmacher Geschaeftsfuehrung: Prof. Dr.-Ing. Wolfgang Marquardt (Vorsitzender), Karsten Beneke (stellv. Vorsitzender), Prof. Dr.-Ing. Harald Bolt, Prof. Dr. Sebastian M. Schmidt

fboers commented 5 years ago

for the next release of my source code I can put the code like this:

new folder: jumeg/base/ with subfolders ioutils template and source code jumeg_base jumeg_logger

jumeg/data/templates

dirs to stay: tools epocher gui this needs some major changes in py files

pravsripad commented 5 years ago

Solved by #206 .