Closed jdammers closed 9 years ago
pravsripad
commented
9 years ago Yes, there is some inconsistency with regard to "fi" throughout the code. It has to be added also to other file names which have simple 'bp1-45hz'... Yes you can fix it :+1:
lukasbreuer
commented
9 years ago Yes, this is a bug. You can fix this if you like.
Von: Juergen Dammers notifications@github.com<mailto:notifications@github.com> Antworten an: jdammers/jumeg reply@reply.github.com<mailto:reply@reply.github.com> Datum: Mittwoch, 10. Dezember 2014 15:57 An: jdammers/jumeg jumeg@noreply.github.com<mailto:jumeg@noreply.github.com> Betreff: [jumeg] filename convention in preproc (#56)
didn't we agree on a postfix for filtered files like "..,fibp1-45Hz-raw.fif"? This convention is not applied in jumeg_preprocessing.apply_filter ("fi" is missing). Shall I fix it?
Reply to this email directly or view it on GitHubhttps://github.com/jdammers/jumeg/issues/56.
Forschungszentrum Juelich GmbH 52425 Juelich Sitz der Gesellschaft: Juelich Eingetragen im Handelsregister des Amtsgerichts Dueren Nr. HR B 3498 Vorsitzender des Aufsichtsrats: MinDir Dr. Karl Eugen Huthmacher Geschaeftsfuehrung: Prof. Dr.-Ing. Wolfgang Marquardt (Vorsitzender), Karsten Beneke (stellv. Vorsitzender), Prof. Dr.-Ing. Harald Bolt,
didn't we agree on a postfix for filtered files like "..,fibp1-45Hz-raw.fif"? This convention is not applied in jumeg_preprocessing.apply_filter ("fi" is missing). Shall I fix it?