Closed pravsripad closed 9 years ago
Hello Praveen,
now I can also reproduce the problem - my choice of files was wiser in terms of hiding my errors ;-) Now I know that the problem is due to missing input sanitation, but I want to make sure I don't leave similar problems.
For the moment call noise_reducer only for single files, not lists of files!
Sorry for the inconvenience, Eberhard
-------- Original Message --------
Subject: Re: [jumeg] jumeg noise reducer error when passing list of files (#85) From: pravsripad pravsripad@gmail.com To: Eberhard Eich e.eich@fz-juelich.de Date: 2015-06-18 11:28
Hello Eberhard,
I am able to reproduce the error by passing two file names as a list. The files are from CAU data and it is passed as shown below:
In [1]: raw_fname = '109925_CAU01A_100715_0842_2_c,rfDC-raw.fif' In [2]: empty_fname = '109925_CAU01A_100715_0844_2_c,rfDC-empty.fif' jumeg_noise_reducer.noise_reducer([raw_fname, empty_fname])
Attached are two error logs, one with verbose=True and the other without. Hope this helps.
It works very nicely if I simply pass one file and I am already using it successfully so far.
Thank you.
Forschungszentrum Juelich GmbH 52425 Juelich Sitz der Gesellschaft: Juelich Eingetragen im Handelsregister des Amtsgerichts Dueren Nr. HR B 3498 Vorsitzender des Aufsichtsrats: MinDir Dr. Karl Eugen Huthmacher Geschaeftsfuehrung: Prof. Dr.-Ing. Wolfgang Marquardt (Vorsitzender), Karsten Beneke (stellv. Vorsitzender), Prof. Dr.-Ing. Harald Bolt,
I will do that. Thank you @ebeich
Looks like always the same problem with
https://github.com/fboers/jumeg/blob/fb_devel_150602_v001/jumeg_noise_reducer_4raw_data.py line 391 ff, in the next version this will be a function in the jumeg_base class
On 18.06.2015 15:22, Praveen Sripad wrote:
I will do that. Thank you @ebeichhttps://github.com/ebeich
— Reply to this email directly or view it on GitHubhttps://github.com/jdammers/jumeg/issues/85#issuecomment-113154231.
Frank Boers Institute of Neuroscience and Medicine - 4 Medical Imaging Physics Forschungszentrum Juelich GmbH 52425 Juelich phone: +49 - (0)2461-61-6005 fax : +49 - (0)2461-61-2820 email: f.boers@fz-juelich.demailto:f.boers@fz-juelich.de http://www.fz-juelich.de/inm/inm-4/DE/Forschung/MEG-Physik/_node.html
Forschungszentrum Juelich GmbH 52425 Juelich Sitz der Gesellschaft: Juelich Eingetragen im Handelsregister des Amtsgerichts Dueren Nr. HR B 3498 Vorsitzender des Aufsichtsrats: MinDir Dr. Karl Eugen Huthmacher Geschaeftsfuehrung: Prof. Dr.-Ing. Wolfgang Marquardt (Vorsitzender), Karsten Beneke (stellv. Vorsitzender), Prof. Dr.-Ing. Harald Bolt,
This is the traceback when passing a list of files instead of a single file.