search

jdan / 98.css

A design system for building faithful recreations of old UIs
https://jdan.github.io/98.css
MIT License
9k stars 296 forks source link

Swap box-shadows with actual borders #154

Closed robert-ryu7 closed 11 months ago

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
98css ✅ Ready (Inspect) Visit Preview Nov 16, 2022 at 8:12AM (UTC)
jdan commented 1 year ago

How come?

On November 16, 2022, Mads Hougesen @.***> wrote:

You can view, comment on, or merge this pull request online at:   https://github.com/jdan/98.css/pull/154

Commit Summary

File Changes (7 files https://github.com/jdan/98.css/pull/154/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/jdan/98.css/pull/154, or unsubscribe https://github.com/notifications/unsubscribe- auth/AACGEJG7B7LPQ4PZGAMZUXTWISJOFANCNFSM6AAAAAASB5ZGGI. You are receiving this because you are subscribed to this thread.Message ID: @.***>

robert-ryu7 commented 1 year ago

Hi @jdan,

You mentioned previously that you prefer consistency (as do I). After giving it some thought I chose to use border image technique for all borders.

border-image uses actual CSS border which allows us to properly position scrollbars inside of an element (i did some comparisons using Win98 VM and scrollbars should be next to border and not over it). The only alternative solution that I know is to use 2 elements, one for overflow and other for border which might be ok but feels too cumbersome.

However, this makes theming a bit more difficult (but not impossible) since you won't be able to simply modify some color variables.

Anyway, if that's too much feel free to close this PR, don't want to go against any project rules. :)

juanigaray commented 11 months ago

I'm gonna close this PR as stale as a housekeeping measure. Please feel free to start a discussion in the discussions or issues sections.