jdan / 98.css

A design system for building faithful recreations of old UIs
https://jdan.github.io/98.css
MIT License
9.2k stars 301 forks source link

Missing scrollbars (proposal inside) #16

Closed BeardedBear closed 4 years ago

BeardedBear commented 4 years ago

Hi !!!

I noticed that the scrollbars were missing, I played a bit on CodePen to try to reproduce them, and I came up with this result: https://codepen.io/BeardedBear/pen/jObVXmV

image

Are you interested? Feel free to retrieve the code if you are :)

however, I never found solutions for Firefox :(

Edit note : Thanks padraigfl for the button trick.

padraigfl commented 4 years ago

Feel free to use mine: https://github.com/padraigfl/packard-belle/blob/master/src/_scss/w98/theme.scss

It's a chrome only fix, mind

Screenshot 2020-04-22 at 12 51 44

BeardedBear commented 4 years ago

@padraigfl yours is really great!

BeardedBear commented 4 years ago

@padraigfl I didn't know that :start:decrement, and :horizontal:decrement (and the others) existed! Thanks for the tip! I took the liberty of updating my Pen with it!

jdan commented 4 years ago

Hey both :) I included these https://github.com/jdan/98.css/blob/32b8da0ae2458a853d708229f1eb3792f768df29/style.css#L445-L480, are they not showing up for you? They show up on my desktop Chrome but it's quite possible I messed something up.

davwheat commented 4 years ago

They appear fine for me (Chrome 81, Windows 10)

padraigfl commented 4 years ago

I didn't actually check 😬 Looking now the bars are there but the buttons aren't, however it works across browsers much better going on a quick comparison there now

AdrianoCahete commented 4 years ago

I have a customization for Firefox scrollbar on my portfolio, but I don't know if it will work for that type of customization: https://github.com/AdrianoCahete/adrianocahete.dev/blob/master/assets/styles/base.styl#L75

jdan commented 4 years ago

@padraigfl @BeardedBear could you let me know what browsers you're both using and if this is still an issue?

padraigfl commented 4 years ago

the buttons are appearing for me now, all looks good!