search

jdan / 98.css

A design system for building faithful recreations of old UIs
https://jdan.github.io/98.css
MIT License
9k stars 296 forks source link

Input type="number" arrows overflow off the input #164

Open juanigaray opened 1 year ago

juanigaray commented 1 year ago

In this deploy, it looks like this:

image

Whereas on main it looks like this

image

juanigaray commented 11 months ago

main is "bad", 9c190beb0a19597c215c9ea8c2e4613ef5604ec2 is good. Bisecting... (edit: none of those commits was good)

juanigaray commented 11 months ago

The first bad commit has my name on it ( 735b3c600658dd598afc193de85b437df1d50528 )

image

juanigaray commented 11 months ago

No, wait! There aren't any actual good commits in the main branch. Which is very weird. But the results of git blame are invalid.

juanigaray commented 11 months ago

Nothing interesting there. But maybe the implementation of the border changed.

juanigaray commented 11 months ago

Oops! The Good commit was from a PR I closed! https://github.com/jdan/98.css/pull/154

juanigaray commented 11 months ago

MWUE has Spin Boxes which illustrate how these arrows should look. See p. 184, figure 8.32