jdan / 98.css

A design system for building faithful recreations of old UIs
https://jdan.github.io/98.css
MIT License
9k stars 296 forks source link

Add `class` alts for `aria-labels` #189

Closed vtlanglois closed 7 months ago

vtlanglois commented 7 months ago

Fixes #91

In this PR:

📈 Impact

Should this PR work as intended, users can now have title bar buttons' aria-labels be in languages other than English, such as the issue's example of using aria-label="Schließen" for a Close button, without causing rendering, accessibility, or localization issues.

📔 Dev Note

I believe that having an example of class and aria-label being used together to show that you can render buttons without completely relying on English text could be helpful. However, I did not know what would be the best way to do this in the documentation. I was thinking of using the issue's example with a window with only a close button, but I'm not certain. If this example seems good, I can add that to this PR.

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
98css ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2024 5:36pm