Closed vtlanglois closed 7 months ago
The latest updates on your projects. Learn more about Vercel for Git βοΈ
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
98css | β Ready (Inspect) | Visit Preview | π¬ Add feedback | Jan 28, 2024 2:09am |
Looks good! Is it possible to apply a filter to the button to get the same effect? (Is it possible to apply this filter to other buttons/icons too?)
No need for my approval to merge these btw. Feel free to use your own discretion β¨
Thanks!
I don't have experience in using filters on SVGs, but I could see it being possible. I could look into this on my free time, ofc no guarantees with work and all. Should this be made into an Issue in case another dev is able to implement this?
In this PR
icon/maximize-disabled.svg
, based on a disabled Maximize title bar button[^1].π Impact
With this additions, users will be able to style windows as if they cannot be maximize. This can be useful when users wish to:
Reasons for Drafting this PR
I have another PR related to title bar buttons up (#189). As that PR could cause merge conflicts with this PR and has changes that, if approved, need to be applied to for disabled maximize buttons to work as intended without English-text
aria-label
s, this will be a draft until action is done on that PR.This prevents a possible bug from arising if work is not done to apply the changes in #189 to this PR.
π Dev Note
I tried looking for examples of the remaining 4 title bar buttons having a disabled state, but couldn't find concrete evidence of that in Windows 98.
[^1]: styling based on multimedia application UIs screenshots from this website: https://guidebookgallery.org/screenshots/win98