Removed --checkmark-top and related top:... code to fix multiline checkboxes[^1]
💭 Reasoning
As stated in #142, if a label was wrapped to be more than one line, the checkbox would be centered but not the checkmark.
[^2]
The source of this issue was due to --checkmark-top forcing a top: 3px onto the checkmark[^1], which seemed to worked as intended until the label became multiline. When disabled, however, the top declaration didn't seem to be doing anything to force the checkmark to appear in the right place.
When removed, no visible changes occurred.
📈 Impact
Should this PR be accepted, this should prevent a noticeable visual bug from occurring.
📔 Dev Note
Does anyone know what a multiline checkbox would look like in W98? Couldn't find any examples of that, nor have I been able to get a VM going with W98 to check.
[^1]: This fix was first reported by @psyklon-project here
[^2]: Image from @metropolis-nostalgia
Fixes #142
In this PR:
--checkmark-top
and relatedtop:...
code to fix multiline checkboxes[^1]💭 Reasoning
As stated in #142, if a label was wrapped to be more than one line, the checkbox would be centered but not the checkmark.
[^2]
The source of this issue was due to
--checkmark-top
forcing atop: 3px
onto the checkmark[^1], which seemed to worked as intended until the label became multiline. When disabled, however, thetop
declaration didn't seem to be doing anything to force the checkmark to appear in the right place.When removed, no visible changes occurred.
📈 Impact
Should this PR be accepted, this should prevent a noticeable visual bug from occurring.
📔 Dev Note
Does anyone know what a multiline checkbox would look like in W98? Couldn't find any examples of that, nor have I been able to get a VM going with W98 to check.
[^1]: This fix was first reported by @psyklon-project here [^2]: Image from @metropolis-nostalgia