jdan / 98.css

A design system for building faithful recreations of old UIs
https://jdan.github.io/98.css
MIT License
9k stars 296 forks source link

Removed `--checkmark-top` to fix multiline checkboxes #191

Closed vtlanglois closed 7 months ago

vtlanglois commented 7 months ago

Fixes #142

In this PR:

💭 Reasoning

As stated in #142, if a label was wrapped to be more than one line, the checkbox would be centered but not the checkmark.

[^2]

The source of this issue was due to --checkmark-top forcing a top: 3px onto the checkmark[^1], which seemed to worked as intended until the label became multiline. When disabled, however, the top declaration didn't seem to be doing anything to force the checkmark to appear in the right place.

Screenshot 2024-01-22 at 5 13 41 PM

When removed, no visible changes occurred.

📈 Impact

Should this PR be accepted, this should prevent a noticeable visual bug from occurring.

📔 Dev Note

Does anyone know what a multiline checkbox would look like in W98? Couldn't find any examples of that, nor have I been able to get a VM going with W98 to check.

[^1]: This fix was first reported by @psyklon-project here [^2]: Image from @metropolis-nostalgia

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
98css ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 10:17pm
juanigaray commented 7 months ago

Thanks!!