search

jdan / 98.css

A design system for building faithful recreations of old UIs
https://jdan.github.io/98.css
MIT License
9k stars 296 forks source link

Used em units for their preferred reactivity #201

Open Dodge100 opened 3 months ago

Dodge100 commented 3 months ago

Updated all pixel units em. This was as per issue #198.

Huge thanks to @benjamingwynn for his help with this as well.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
98css ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 3:49am
tazjin commented 3 months ago

Cool!

FWIW, the preview that vercel generated above looks ... odd ... for me:

Screenshot 2024-06-12 at 16-55-38 98 css

This screenshot was taken in Firefox, but it looks the same way in Chromium.

tazjin commented 3 months ago

Actually the breakage in Chromium looks a little different:

98_chrome-1718200635

Dodge100 commented 2 months ago

all the bugs have been fixed! they were mostly just me typing 10 instead of 1. :P

Dodge100 commented 2 months ago

actually chromium looks weird 😞

Dodge100 commented 2 months ago

i found the issue. a lot of the elements are non-repsonsive.

tazjin commented 2 months ago

input[type="number"] still has an odd height in the last vercel deployment, otherwise everything seems to look more reasonable.

The default scale of stuff did change however, everything seems to be about 25% larger by default now, which leads to the pixelated fonts rendering blurry by default.

Dodge100 commented 2 months ago

the size being ~25% larger is due to no font size being set so it defaults to 16px. I am working on a patch to fix all of the elements using transformX/Y.

bootrino commented 1 month ago

Will this be merged?

Dodge100 commented 1 month ago

i've been a bit busy with irl stuff at the moment so haven't had much time to work on this. i do plan on working on it towards the start of august (no promises though).