Add MenuBar Component with Menus

jdan / 98.css

A design system for building faithful recreations of old UIs

https://jdan.github.io/98.css

MIT License

9.17k stars 301 forks source link

Add MenuBar Component with Menus #80

Closed stephdin closed 4 years ago

stephdin commented 4 years ago

This is my first wip try implementing the MenuBar.

menubar_98css

Things added:

a menu-bar button class
a separator which can be used anywhere
a menu component

Issues:

probably should use own color variables
other menus don't open when hovered
keyboard navigation not (yet) possible
unsure about implementation of separator
unsure about code quality :sweat_smile:

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/jdan/98css/o83amm5j9 ✅ Preview: https://98css-git-fork-stephdin-master.jdan.now.sh

jdan commented 4 years ago

Thanks for this, this is a fun one. Will require a lot of love and care to merge as to not break accessibility.

ynotrusso commented 4 years ago

Same problem as #58 in terms of accessibility?

jdan commented 4 years ago

Looks like this closed because I deleted the master branch in favor of main, sorry! Feel free to re-open continuing our discussion