Resolve a promise to an empty string instead of rejecting it on local theme in settings.json

jdan / cleaver

30-second slideshows for hackers

http://jdan.github.io/cleaver

MIT License

4.02k stars 305 forks source link

Resolve a promise to an empty string instead of rejecting it on local theme in settings.json #160

Closed nuno-silva18 closed 7 years ago

sudodoki commented 7 years ago

I don't think title is representing what changed in code. Maybe, you didn't push some changes?

sudodoki commented 7 years ago

This should fix #147. @nuno-silva18 Can you please squash your commits? Sample instruction just in case you need one. If you can't or don't want to do that, I can do it myself.

nuno-silva18 commented 7 years ago

@sudodoki I tried to squash the commits through GitKraken but I'm not sure if this is how it's supposed to look like, I'd really appreciate some help here!

sudodoki commented 7 years ago

Closing this in favor of https://github.com/jdan/cleaver/pull/165