search

jdan / cleaver

30-second slideshows for hackers
http://jdan.github.io/cleaver
MIT License
4.02k stars 305 forks source link

Possible enhancement: rewrite to es6 #164

Open sudodoki opened 7 years ago

sudodoki commented 7 years ago

Just throwing it out there. Maybe, someone w/ much free time on their hands might do that. Incorporating fixes for all possible design issues and pull request… 🤔

hhzl commented 7 years ago

What would be the benefit of this?

sudodoki commented 7 years ago

@hhzl no visible benefit apart from shorter syntaxes at places and excuse to rewrite pieces ones doesn't like

hhzl commented 7 years ago

Maybe template strings could be put to good use making the code easier to read and maintain...

https://developers.google.com/web/updates/2015/01/ES6-Template-Strings

On 1/25/17, Джон, просто Джон notifications@github.com wrote:

@hhzl no visible benefit apart from shorter syntaxes at places and excuse to rewrite pieces ones doesn't like

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/jdan/cleaver/issues/164#issuecomment-275161189

hhzl commented 7 years ago

I mean only for the part generating the result html presentation file, not within the html presentation. That should probably better stay JavaScript 5.

That would mean replacing the mustache template system, http://mustache.github.io/. Not sure if it is worth the effort.

The issue could then be named

Replace the mustache template system with ES6 template strings.