search

jdan / cleaver

30-second slideshows for hackers
http://jdan.github.io/cleaver
MIT License
4.03k stars 305 forks source link

Added metadata 'encoding' to define html document charset #35

Closed soyrochus closed 11 years ago

soyrochus commented 11 years ago

Cleaver in its current HEAD doesn´t facilitate unicode text, for example German, Dutch, Spanish in UTF-8, symbols etc. I´ve added the medata parameter 'encoding' which allows to specify the charset

jdan commented 11 years ago

Thanks for this! I went ahead and made some tweaks and pushed to a new branch, see: 3301a8b8abc1d593058e749b60898a776749962e

Do you think it's fair to default this new field to utf-8? Everything else looks perfect.

soyrochus commented 11 years ago

According to the standard the web browser is supposed to figure it out itself. But current practice seems to be to put an encoding in by default ( http://htmlpurifier.org/docs/enduser-utf8.html) so your change seems the correct approach.

Thanks for Cleaver! Its simplicity, but still very complete feature-set, made me give it a try. I´ll be using it for three separate presentations next week.

Iwan

On 7 September 2013 07:05, Jordan Scales notifications@github.com wrote:

Thanks for this! I went ahead and made some tweaks and pushed to a new branch, see: 3301a8bhttps://github.com/jdan/cleaver/commit/3301a8b8abc1d593058e749b60898a776749962e

Do you think it's fair to default this new field to utf-8? Everything else looks perfect.

— Reply to this email directly or view it on GitHubhttps://github.com/jdan/cleaver/pull/35#issuecomment-23981784 .

http://skitr.com/iwanvanderkleijn.asc Protect you privacy and identity. Create and share your own OpenPGPhttp://en.wikipedia.org/wiki/Pretty_Good_Privacykey(s) Mine are at http://skitr.com/iwanvanderkleijn.asc

jdan commented 11 years ago

Awesome, fix landed in 0cd846acf65065fbaa90ddfe053b29b0298722de. Thanks for your contribution! (and thanks for teaching me about content encodings).

Glad you like the library, keep me posted on your experience using it