search

jdan / cleaver

30-second slideshows for hackers
http://jdan.github.io/cleaver
MIT License
4.03k stars 305 forks source link

Feature/navigation extended #56

Closed SoftlySplinter closed 10 years ago

SoftlySplinter commented 11 years ago

Extended the navigation to allow PgUp to go backwards and PgDn to go forwards (to help compatibility with some clickers).

Added some basic paging to make presenting a little bit easier for anyone who wants a bit more control.

Disclaimer: I'm not that used to JavaScript, I did test in recent versions of Opera and Chromium, but if its rubbish code please do point me in the directions I should be looking :-)

jdan commented 11 years ago

I'm a big fan of adding PgUp and PgDn - sounds like a fair addition to me. I'm not totally sold on the paging aspect, though.

SoftlySplinter commented 11 years ago

Up to you, its just something I've personally been missing from cleaver, being able to do things like jump to the end or to detail slides is something I've found really useful every so often with PowerPoint/Impress.

jdan commented 11 years ago

Hm, I'm still not a big fan of the idea - but I'm trying to figure out a way to make this extensible enough such that implementing it on your own would be easy.

Let me play around with external scripts (the same way we allow users to include their own stylesheets). I bet something cool could come out of that. I'll keep you posted.

jdan commented 10 years ago

Okay, here's my update!

Today I'm going to accept your changes to navigation.js, so users can use PgUp and PgDown. However, with the addition of https://github.com/jdan/cleaver/blob/master/docs/themes.md, I'm going to keep the "paging" feature out of cleaver, with the intention that you can easily add your own scripts.

jdan commented 10 years ago

Landed in c29fda58796444fb1c49023a7acb95857fb69545. Thanks :)