search

jdan / dynamo.js

Cycles through bits of text in place
http://jdan.github.io/dynamo.js/
MIT License
624 stars 65 forks source link

data-callback accepts everything as string #18

Closed ganesshkumar closed 11 years ago

ganesshkumar commented 11 years ago

Following is a line from the test.html in the repo <span id="digit1" data-callback="bump(2)" >0</span>

when the callback function is actually called, it throws an error Uncaught TypeError: string is not a function dynamo.js:100 .

I tried to log the type of the variable callback in dynamo.js and it said it returned string but a function is expected

jdan commented 11 years ago

Must've happened when I linted the code. I'll take a look once I'm near my computer.

Thanks!

jordan scales scalesjordan@gmail.com http://jordanscales.com

On Sun, Sep 1, 2013 at 5:03 PM, Ganessh Kumar notifications@github.com wrote:

Following is a line from the test.html in the repo <span id="digit1" data-callback="bump(2)" >0</span> when the callback function is actually called, it throws an error Uncaught TypeError: string is not a function dynamo.js:100 .

I tried to log the type of the variable callback in dynamo.js and it said it returned string but a function is expected

Reply to this email directly or view it on GitHub: https://github.com/jdan/dynamo.js/issues/18

ganesshkumar commented 11 years ago

I have looked into the code and found the cause of this issue. I can send you pull request with the fix

jdan commented 11 years ago

That'd be perfect :)

jordan scales scalesjordan@gmail.com http://jordanscales.com

On Sun, Sep 1, 2013 at 5:18 PM, Ganessh Kumar notifications@github.com wrote:

I have looked into the code and found the cause of this issue. I can send you pull request with the fix

Reply to this email directly or view it on GitHub: https://github.com/jdan/dynamo.js/issues/18#issuecomment-23633377