Let's cache and simplify it a bit!

jdan commented 12 years ago

Bug on line 26 - el.find(...) - since you ended up changing 'el' back to 'v'. Any way to add that before I merge?

genesiscz commented 12 years ago

Done. Thanks for the fast response, nice plugin!

jdan commented 12 years ago

Just wanted to let you know it broke :) If you can prove this works on all browsers (Chrome OSX 10.7) feel free to submit a new pull request. In the meantime, I have reverted everything back. (By checking out an old commit # and re-committing.)

Some errors I came across were

using v instead of $(v) doesn't seem to cut it
I went ahead and put v = $(el) (I changed the function to accept 'i' and 'el') but it still didn't work
either nothing happened or the container was spread very wide and all cycles were displayed

My apologies for not keeping your changes, but unfortunately they did not work for me.

genesiscz commented 12 years ago

Well, do not apology, it is my fault.

jdan / dynamo.js

Let's cache and simplify it a bit! #5