search

jdan / tota11y

an accessibility (a11y) visualization toolkit
http://khan.github.io/tota11y/
MIT License
5.04k stars 278 forks source link

Bad distribution system. #157

Open TheGreyCardinal opened 5 years ago

TheGreyCardinal commented 5 years ago

Hi.

You have a very useful and cool project. Thank you.

But... You have an extremely uncomfortable and strange distribution system.

Your tool needs 1(!) file to work. Which simply connects to the page in any convenient way, as the user/developer wants.

The question is why you have it: • There are 100500 files for everything in the world (less, webpack, plugins, tempalates, etc.) in the releases/guithab, but there is no file itself?

Why does a user of your tool have to deploy an entire npm-system with many third-party tools to connect 1(!) file?

• Why is there no 1(!) simple link to download this 1(!) script? Why do we have to get it by the method of studying the page code?

I absolutely don't understand what such difficulties are when you can simply provide a direct link to them: https://khan.github.io/tota11y/dist/tota11y.min.js

It's very strange to see such a solution in spite of the steepness and usefulness of your project. Why such difficulties, why? You only need 1(!) file for your work, not all that heap (excuse me) that you offer as a distribution model.

Please don't kill your project with this.

Thank you for your attention, I hope you understand. Be simpler and it will make everyone feel more comfortable.

p.s. I would like to see a version that is not minified. It would be interesting to study it, learn something new.

Ryuno-Ki commented 5 years ago

Hm, I'm not sure, whether you think on server-side (= Node.js) here as well. I agree, for the frontend, a single file should be enough. But if you want to contribute, several smaller files are more helpful. You can study the setup by looking at this repo.

TheGreyCardinal commented 5 years ago

Hm, I'm not sure, whether you think on server-side (= Node.js) here as well. I agree, for the frontend, a single file should be enough. But if you want to contribute, several smaller files are more helpful. You can study the setup by looking at this repo.

Okay, why not both? For front and server? It is very easy to do.)

Ryuno-Ki commented 5 years ago

Normally too much noise in git. But perhaps the team could drop a link to a CDN? I'm not a contributor.

TheGreyCardinal commented 5 years ago

Normally too much noise in git. But perhaps the team could drop a link to a CDN? I'm not a contributor.

It's a question of one link. Maybe two.) One commit. What kind of noise are we talking about?

Ryuno-Ki commented 5 years ago

If you track the built, minified library with git, every change on the source code would modify the build target. Due to minifying it is hard to tell what changed there. Thus, noise.

TheGreyCardinal commented 5 years ago

If you track the built, minified library with git, every change on the source code would modify the build target. Due to minifying it is hard to tell what changed there. Thus, noise.

Minified single-file library is made anyway - for their site to use the latest version. So this is not an extra job - it is made, anyway.

As already written above, the whole question - in the addition of a single link). It is not difficult to do.