search

jdauphant / ansible-role-nginx

Ansible role to install and manage nginx configuration
655 stars 302 forks source link

Always_run is deprecated #161 #162

Closed jadjay closed 7 years ago

jadjay commented 7 years ago

It is required to prefer check_mode: no

It remove a warning during deployement

jadjay commented 7 years ago

Please could you merge this ?

jdauphant commented 7 years ago

@jadjay Have you see the review? Do you need help?

jdauphant commented 7 years ago

Hello @jadjay, Where are you with the pull request ?

If you don't have time, @pieterlexis may be able to help on this feature. One of the solution is simple to implement: We can check if nginx_stream_params isn't an empty list and not nginx_stream_configs not an empty map.

jdauphant commented 7 years ago

I close this PR, #169 with the stream fix have been merged ! For "Always run" #140 will be merge when Ansible 2.3 will be available.

Thanks for your help