jdauphant / ansible-role-nginx

Ansible role to install and manage nginx configuration
655 stars 302 forks source link

the replacement of ';' is incorrect if ';' in a paramter. #170

Closed suupic closed 7 years ago

suupic commented 7 years ago

for example: add_header Content-Disposition 'attachment; filename="$arg__upd"'; the configuration file will be rewrite to:

   add_header Content-Disposition 'attachment;
   filename="$arg__upd"';
jdauphant commented 7 years ago

Thanks @suupic for the MR. You have also this problem with the new notation ?

nginx_sites:
   test: 
      - |
        listen 443 ssl;
        server_name foo.example.com;
        add_header Content-Disposition 'attachment; filename="$arg__upd"';

In the futur, the idea is to replace the old notation completely by the new notation (If you have feedbacks about that, don't hesitate :)

suupic commented 7 years ago

@jdauphant it works :)