search

jdavidbakr / mail-tracker

Package for Laravel to inject tracking code into outgoing emails.
MIT License
562 stars 129 forks source link

Handle null value and non existant value #229

Closed bretto36 closed 11 months ago

bretto36 commented 11 months ago

In our project i have handled saving the data to a storage driver myself (added it well before it was included in the current package).

When adding a test for this functionality in my project the latest version of the code throws an error about attempting to get a value from a null.

I've seen you check for the values presence in other methods in this class, so i added it here too.

bretto36 commented 11 months ago

@jdavidbakr Not sure if i'm supposed to tag you or not. Thanks for the package, we've been using it for probably 4-5 years now.