search

jdavisclark / JsFormat

Javascript formatting for Sublime Text 2 & 3
1.42k stars 222 forks source link

upgrade to js-beautify v1.5.1 #108

Closed jdavisclark closed 10 years ago

jdavisclark commented 10 years ago

Fixes the following for sure:

jdavisclark commented 10 years ago

Looks like the addition of the jsbeautifier dependency on the "six" package is causing import issues again. This is an issue with the hell that is using 3rd party dependencies with sublime plugins. But it might help if jsbeautifier used some form of relative imports.

bitwiseman commented 10 years ago

You're talking about what is described in https://docs.python.org/2.5/whatsnew/pep-328.html ?

jdavisclark commented 10 years ago

Yep. I was going to play around with it some before I bugged you about it; I ran in to the issue this morning when I was going to try a quick upgrade. We have had the similar issues before with the unpackers, this just adds a dependency in a higher level directory than I had been copying over locally before.

My thought was that relative imports might be friendlier for downstream applications since it assumes a little less about the environment. As far as downstream applications go, Sublime is just especially annoying because plugins have to be fully packed up with all their dependencies, and sublime itself doesn't expose anything outside the normal stdlib to help you out with 3rd party dependency management (like virtualenv would).

I will probably be able to resolve this on my end, but I figured it was a decent time to make note of it and maybe see if it could be improved a little upstream.

bitwiseman commented 10 years ago

Could you file an upstream issue as well? It looks totally doable.