search

jdbc-observations / datasource-micrometer

Micrometer Observation API instrumentation and Spring Boot 3 Auto-Configuration for JDBC APIs
Apache License 2.0
50 stars 8 forks source link

Issue-22 #23

Closed AnatoliyYakimov closed 11 months ago

AnatoliyYakimov commented 11 months ago

Fix NPE in DataSourceObservationListener#afterMethod when ResultSet#next throws an exception. Issue #22

AnatoliyYakimov commented 11 months ago

I think we also should mark field MethodExecutionContext#result as @Nullable and check all code with static analyzer like SonarLint or Intellij IDEA buldled analyzer.

ttddyy commented 11 months ago

@AnatoliyYakimov Thanks for the PR. I have merged, polished, and pushed it to main.