search

jdbc-observations / datasource-micrometer

Micrometer Observation API instrumentation and Spring Boot 3 Auto-Configuration for JDBC APIs
Apache License 2.0
50 stars 8 forks source link

Add DATASOURCE_DRIVER and DATASOURCE_POOL keys to all observations #24

Closed AnatoliyYakimov closed 11 months ago

AnatoliyYakimov commented 11 months ago

I think that DATASOURCE_DRIVER and DATASOURCE_POOL should apply to all observations. Without this keys we cannot separate metrics in Prometheus when application have multiple datasources. ResutSet/Query metrics without separation by pool doesn't make sense.

ttddyy commented 11 months ago

Thank you for the PR. I have merged, polished, and pushed the change.