search

jdcalkins / ng2-data-table

DataTable - Simple table component with sorting, pagination, and row select/multi-select for Angular2
MIT License
7 stars 7 forks source link

DataTableModule is not an NgModule #15

Closed itsnotvalid closed 7 years ago

itsnotvalid commented 7 years ago

angular version: 2.4.3 anuglar-cli version: 1.0.0-beta25.5

I just started a new project to try things with angular2, but apparently I run into bugs of some components keeping to remind me that it doesn't fit together. Now what it gives to me is that this module is not written in the format required by angular 2.4.3.

jdcalkins commented 7 years ago

https://github.com/angular/angular-cli/issues/3426

It appears there may be an issue with angular-cli. I'll have to take a closer look at the ng2-data-table package to make sure it's AOT compliant. #19

jdcalkins commented 7 years ago

Resolved with package release v1.0.0

ericalbers commented 7 years ago

This is NOT closed. ng -v gives:

angular/cli: 1.2.7 node: 6.11.1 os: win32 x64 angular/animations: 4.3.3 angular/cdk: 2.0.0-beta.8 angular/common: 4.3.3 angular/compiler: 4.3.3 angular/core: 4.3.3 angular/flex-layout: 2.0.0-beta.8 angular/forms: 4.3.3 angular/http: 4.3.3 angular/material: 2.0.0-beta.8 angular/platform-browser: 4.3.3 angular/platform-browser-dynamic: 4.3.3 angular/router: 4.3.3 angular/cli: 1.2.7 angular/compiler-cli: 4.3.3 angular/language-service: 4.3.3

JonesCola commented 7 years ago

I am also having this issue. It works fine until I try to install anything build targeting angular 2 (I think). My work around was to install then run "npm install". then I run "ng build -w". it throws the error but if I hit space in any of my code files and save then it works just fine. I dont know if that helps anyone else...