search

jdcataldo / grunt-mocha-phantomjs

A simple grunt wrapper for mocha-phantomjs to allow for ci integration
MIT License
70 stars 40 forks source link

Use phantomjs' binary path property instead of trying to find it manually #41

Closed ade closed 9 years ago

ade commented 9 years ago

The current lookup method fails to find phantomjs in some scenarios. PhantomJS exports a path property to its' binary which is better to use.

jdcataldo commented 9 years ago

This fails if you have phantomjs installed globally which people do on their CI environment.

ade commented 9 years ago

I see. Perhaps a solution using both is better?

ade commented 9 years ago

I've updated my branch to only use the module's path property as a fallback.