search

jdcataldo / grunt-mocha-phantomjs

A simple grunt wrapper for mocha-phantomjs to allow for ci integration
MIT License
70 stars 40 forks source link

Fixed issue where grunt task couldn't find pantomjs executable on Windows #42

Closed KrisSiegel closed 9 years ago

KrisSiegel commented 9 years ago

So I'm not sure if or when this issue occurred but I can no longer run grunt-mocha-phantomjs on Windows machines. When looking at the phantomjs package it actually puts the executable in a different location than what this grunt plugin was looking for. So I went ahead and updated this. This makes it work in Windows again.

Unfortunately I have no boxes at the moment (or time) to setup a VM to verify that this does or does not break nix platforms. So this should most likely not be simply merged in. If someone could verify that would be awesome otherwise I'll get a chance to possibly later in the week.

jdcataldo commented 9 years ago

This should be fixed with the latest version.

KrisSiegel commented 9 years ago

Oh I had no idea that .bin existed; looks like a better way to go than my method. 1.0.2 seems to be working just fine. Thanks!