search

jdcataldo / grunt-mocha-phantomjs

A simple grunt wrapper for mocha-phantomjs to allow for ci integration
MIT License
70 stars 40 forks source link

Failed tests don't fail the build #5

Closed bergie closed 11 years ago

bergie commented 11 years ago

Currently if you have failing tests, the Grunt build will still complete, which means CI environments like Travis think everything works.

✖ 1 of 106 tests failed:

1) Network with a simple graph should contain two nodes:
   TypeError: 'null' is not an object (evaluating 'n.processes')
    at file:///home/bergie/Projects/noflo/noflo/spec/Network.js:88
    at file:///home/bergie/Projects/noflo/noflo/node_modules/mocha/mocha.js:4039
    at file:///home/bergie/Projects/noflo/noflo/node_modules/mocha/mocha.js:4404
    at file:///home/bergie/Projects/noflo/noflo/node_modules/mocha/mocha.js:4463
    at next (file:///home/bergie/Projects/noflo/noflo/node_modules/mocha/mocha.js:4330)
    at file:///home/bergie/Projects/noflo/noflo/node_modules/mocha/mocha.js:4339
    at next (file:///home/bergie/Projects/noflo/noflo/node_modules/mocha/mocha.js:4287)
    at file:///home/bergie/Projects/noflo/noflo/node_modules/mocha/mocha.js:4307
    at timeslice (file:///home/bergie/Projects/noflo/noflo/node_modules/mocha/mocha.js:5279)

Done, without errors.
jdcataldo commented 11 years ago

Good catch. Now throwing the correct exit code.