search

jdcataldo / grunt-mocha-phantomjs

A simple grunt wrapper for mocha-phantomjs to allow for ci integration
MIT License
70 stars 40 forks source link

Path to mocha-phantomjs executable is wrong when running on Windows #7

Closed okonet closed 11 years ago

okonet commented 11 years ago

It seems the path to mocha-phantomjs is wrong when running on Windows. It should have *.cmd.

jdcataldo commented 11 years ago

good catch. will also need to add the following to line 42. feel free to submit a pull request.

  if (process.platform === 'win32') {
   bin += '.cmd'
  }
okonet commented 11 years ago

Yeah, I'm submitting the pull request right now

Sincerely yours

Andrey Okonetchnikov

@okonetchnikov http://okonet.ru

On Thursday, 18. April 2013 at 18:34, Justin Cataldo wrote:

good catch. will also need to add the following to line 42. feel free to submit a pull request. if (process.platform === 'win32') { bin += '.cmd' }

— Reply to this email directly or view it on GitHub (https://github.com/jdcataldo/grunt-mocha-phantomjs/issues/7#issuecomment-16587620).