search

jdeath / homeassistant-addons

MIT License
65 stars 16 forks source link

Update README.md #9

Closed mxbchr closed 1 year ago

mxbchr commented 1 year ago

In the original PR I edited the wrong Readme file. It was the main repository readme, not the changdetection addon specific. Sorry for that.

It belongs here, not in the main repository readme.

mxbchr commented 1 year ago

Final thing: can you please 1 up the version in the config file, so that the addon can update? https://github.com/jdeath/homeassistant-addons/blob/c39fe97c3331c1662c2cd495937a64845cf04005/changedetection/config.json#L29

Not sure what the "upstream" thing means and if it also has to be 1 up. https://github.com/jdeath/homeassistant-addons/blob/c39fe97c3331c1662c2cd495937a64845cf04005/changedetection/config.json#L27

jdeath commented 1 year ago

done. The versions are to sync it with the main dockerfile. I have a job that automatically updates the addon when a new docker is updated. Hopefully it will work

mxbchr commented 1 year ago

Nice. Just updated the addon from your repository in HA and can confirm both plaintext and playwright fetching works fine. Thank you!