jdecicco16 / mupen64plus

Automatically exported from code.google.com/p/mupen64plus
0 stars 0 forks source link

SaveStatePath has no effect #460

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Describe your system:
 - Operating System (be specific): Gentoo amd64
 - Machine type (32-bit or 64-bit): 64-bit
 - Mupen64Plus version: current dev
 - Plugins used: default

Describe the problem:

The SaveStatePath path option doesn't seem to work.  I have it set as:

SaveStatePath = "/home/user/data/apps/games/Nintendo/Nintendo 64/Saves"

but m64 always saves both game data and states to 
/home/user/.local/share/mupen64plus/save/ regardless.

Also, a semi-related question:  should SaveStatePath apply to both game data 
(the battery-backed RAM; drawing a blank on the technical term) as well as save 
states, or will it only apply to save states?  I may have a feature request to 
add about this, but I'd like to get a better understanding of how this works 
first.

Thanks.

Original issue reported on code.google.com by nitro322@gmail.com on 5 Oct 2011 at 1:30

GoogleCodeExporter commented 8 years ago
Can you please test 
https://bitbucket.org/ecsv/mupen64plus-core/changeset/5ba207d8a198 (this repo 
will disappear when Richard merged the change)

SaveStatePath should apply to both game data and save states. Please open 
another bug (which I can mark as enhancement) that asks for another 
configuration option.

Original comment by s...@narfation.org on 6 Oct 2011 at 9:34

GoogleCodeExporter commented 8 years ago

Original comment by s...@narfation.org on 6 Oct 2011 at 9:36

GoogleCodeExporter commented 8 years ago
I just did a couple quick test, but yes, that seemed to work perfectly.  I 
would like to confirm that I tested properly, though, as I'm not very familiar 
with using mercurial (and similar systems) and I'm not sure exactly what you 
mean by changeset.

I clicked on the link you provided, saw that two files had changed and diffs 
were available, so I copy/pasted the diffs to a local file and patched the 
latest source from the main repo, then built as usual.  I'm sure there's a much 
easier way of doing what you asked, but function-wise is that a valid test?

Thanks for the quick fix.

Original comment by nitro322@gmail.com on 7 Oct 2011 at 3:22

GoogleCodeExporter commented 8 years ago
Yes, this is a valid test. It is easier to change your ebuild (just for the 
test) to point to my repo and build that instead of the one from richard42.

I hope that Richard merges that stuff soon(tm).

Original comment by s...@narfation.org on 7 Oct 2011 at 9:32

GoogleCodeExporter commented 8 years ago
It is now merged

Original comment by s...@narfation.org on 8 Oct 2011 at 5:11