jdecked / twemoji

Emoji for everyone.
https://jdecked.github.io/twemoji/v/latest/preview-svg.html
MIT License
1.04k stars 62 forks source link

Inconsistent pupil colors #30

Open winterClover opened 1 year ago

winterClover commented 1 year ago

Unlike the rest of the emojis, emojis with wide eyes has black pupils instead of brown.

The rolling eyes emoji and the old versions of pleading/holding back tears emoji are an exception in that they have brown pupils.

barkloaf commented 1 year ago

the difference with the pleading and holding back tears emojis here is that they have much larger pupils and also have irises. changing those large pupils to black (as was done in #6) makes them look very out-of-place, and my guess is that some of that has to do with that size difference. having two large black dots in the middle of the emoji like that just looks very weird. as stated in my comment on #27, I think that there's nothing wrong with the original pleading emoji and that it shouldn't've been changed. I think that the primary issue with the holding back tears emoji is not the pupils and irises, but the shape of the sclera (the white part of the eye) and the location of the iris and pupil within it.

ultimately, I think that the pleading face and holding back tears emojis should be left out of this discussion about pupil color because they're not very comparable to the other 5 emoji. I think making the rest of the 5 consistent (either as black or as brown) is a worthwhile question, though

winterClover commented 1 year ago

I personally think they should be brown as to be more inline with the rest of the emojis

winterClover commented 1 year ago

On the new pleading/holding back tears emojis, they now have large black pupils. which makes them now part of the other 4 emojis to have black eyes.

image

winterClover commented 1 year ago

I don't have much of an opinion on the changes, but I do take issue with adding inconsistency where there was once wasn't.