search

jdegoes / functional-scala

The repository for the Functional Scala workshop.
178 stars 101 forks source link

Complex Coding ? #5

Open kali786516 opened 4 years ago

kali786516 commented 4 years ago

Hi John,

why your coding style is super complex ? can you please change your coding style to something meaningful and less complex.

Thanks

fanf commented 4 years ago

Hi @kali786516 ,

As written, this issue is not actionnable, which is a bad practice (in general, but on the internet, without interactive feedback, even more so). Since your main critism is extremely judgemental (with words like "style", "meaningful", "complex") and not factual (something like "this specific piece of code is hard to undestand for someone like myself who has that experience/context/etc, and I didn't saw explanation/doc, it could be annotated with info), it can even be considered as an attempt to troll.

So, given that you are on a project related to a workshop whose goal is to teach functionnal programmation in scala, can you be more specific about the problem you see in that project? As far as I understand, your concern is about "complexity": did you try to attend the workshop so that its concepts are explain to you? You criticize "coding style", do you have better option to propose (and which relevant in the context of the goal of that project)?

You can also learn about how to ask better question, for example here: http://www.catb.org/~esr/faqs/smart-questions.html (but else, just search for "asking good questions", the internet is full of resources on that topic).

Hope it helps and that you will get answer to your questions.