Closed 0b1kn00b closed 13 years ago
Have just seen that while applying another pull request (it has been so much time.........); of those 5 fixes; 3 and 4 have already been applied; can you confirm 1 & 5 are still needed? (I can't really juge for 1 as I don't use the Injector) I've done 2 in my repo and will merge it with other forthcoming changes..
Should I merge this pull request?
On my side; I really don't know the injector usages well; it looks like some optional parameters are no more allowed. Who's using it may be able to answer that question. (about 'fix for cpp typing bug'). All others look mergeable to me (some fixes (3 and 4) were already merge from my fork).
The cpp compiler craps out using Injector, this fixes that problem.