jdejaegh / irm-kmi-ha

Home Assistant weather provider using data from Belgian IRM KMI 🇧🇪 🇱🇺 🇳🇱
MIT License
40 stars 0 forks source link

Shifted values and missing day #8

Closed patriiiiiiiiiick closed 7 months ago

patriiiiiiiiiick commented 7 months ago

On the following screenshot, met.no data above and IRM below:

Screenshot_20240121-004407

Sunday temperature should go to 6°C instead of zero. And Thursday is missing.

While reporting this, Sunday got fixed but Wednesday vanished. This all happened between midnight and 1.00. Screenshot_20240121-004933~2

For reference: Screenshot_20240121-005711 Have they inverted the tonight and Sunday values?

Also of interest: Wednesday's night value is higher the during the day. This might have wrecked havoc in your logic.

jdejaegh commented 7 months ago

Thanks for opening the issue.

I assume that you are using this custom card for your dashboard: https://github.com/pkissling/clock-weather-card

I see two issues here: the first one where Sunday temperature was -2°C, 0°C instead of -2°C, 6°C (your expected values); the second one where the days are not showing on the card.

Incorrect Sunday temperature As I don't have any data to reproduce it I cannot really do much here. Could you provide at least a screenshot of the IRM app with the same location?

Missing days on the card Using the screenshot you provided for this issue, I mocked the forecast value to return the conditions and temperatures shown in the IRM app. When used on my dashboard, I conclude that the issue is coming from the custom card you use. Below is a screenshot of two cards showing this weather data. On top, your custom card; below, the stock Lovelace weather card. The stock card shows all the days, including Wednesday; while the custom card does not.

If the IRM API says that the temperature is higher during the night (13°C) and lower during the day (12°C), it seems weird for the integration to swap the values. I suggest to open an issue on the custom card repository instead.

Screenshot 2024-01-21 at 14-42-12 Overview – Home Assistant

patriiiiiiiiiick commented 7 months ago

I assume that you are using this custom card for your dashboard: https://github.com/pkissling/clock-weather-card

Correct

Could you provide at least a screenshot of the IRM app with the same location?

This is the last screenshot I put.

But yeah, it all seems linked and due to the custom card.

Thanks for your time!

jdejaegh commented 7 months ago

I went through the issue you opened on the custom card repository and the comment https://github.com/pkissling/clock-weather-card/issues/324#issuecomment-1902713407 has a good point. Home Assistant documentation is not about night or day temperature but lower and higher.

I reopen this and will fix the attributes when I can.

This will avoid other edge cases and ensure that the integration follows Home Assistant documentation. Thanks for reporting this!