search

jdel / sspks

A very simple Synology Package Server, reverse engineered from the official Synology package repository and SynoCommunity.
GNU General Public License v3.0
254 stars 64 forks source link

Get thumb 120 from package #26

Closed benrubson closed 7 years ago

benrubson commented 7 years ago

Hello,

This PR extracts thumb 120 image from the package itself, so that we don't have to generate it ourselves. Note that I use the 256x256 package icon for this, which is what Synology also does.

Thank you 👍

Ben

benrubson commented 7 years ago

I'll add a new commit here :)

jdel commented 7 years ago

@mbirth can I let you handle this one ? It looks OK to me as it shouldn't break backwards compatibility with old packages that don't have a 256 icon.

benrubson commented 7 years ago

I plan to add a commit which will also extract screenshots from package. Screenshots are not official in packages, but we can easily add them during package building. They will then be automatically extracted, which I think is nice to have 👍

mbirth commented 7 years ago

@benrubson Can you submit this screenshot thingy as a separate PR? So I can merge this one.

benrubson commented 7 years ago

I'm ready to commit in a few seconds !

benrubson commented 7 years ago

Tested with 3 screenshots in a package (screen_1.png, screen_2.png, screen_3.png), it works perfectly 👍