search

jdel / sspks

A very simple Synology Package Server, reverse engineered from the official Synology package repository and SynoCommunity.
GNU General Public License v3.0
254 stars 64 forks source link

Make Quick Inst enabled by default #29

Closed benrubson closed 7 years ago

benrubson commented 7 years ago

Hello,

If quick installation is not enabled, and we don't have a WIZARD_UIFILES directory in the package, a default wizard appears in the background, whereas installation is processing... When installation is finished, wizard is still displaying, which does not make sense...

This PR then avoids this. Note that quick installation is enabled for almost all Synology packages.

Thank you 👍

Ben

jdel commented 7 years ago

Thanks for your PRs Ben, I will have a look at them later on today.

jdel commented 7 years ago

Thanks for the PRs. I will review #26 and #29 tomorrow.

benrubson commented 7 years ago

Thank you Julien !

jdel commented 7 years ago

I haven't tried this PR, but are we sure that the synology will use this info over what's specified in the INFO file inside the package ?

My understanding is that the syno will process the INFO file from the package as opposed to the JSON we give it which is just to display the package in package center.

benrubson commented 7 years ago

These 3 parameters can't be set in the INFO file : https://developer.synology.com/developer-guide/synology_package/INFO_optional_fields.html This is quite understandable as they change how the Package Center initiates the download / installation process. Thank you 👍

jdel commented 7 years ago

Oh wow, I wish I had this documentation when i started SSPKS, many hours would have been saved !

As you can see, I haven't been making packages in a long time ! 😆

benrubson commented 7 years ago

^^ Thank you for merging 👍

jdel commented 7 years ago

No worries, help is much appreciated ! Let's make SSPKS great again ! 🤣