search

jdel / sspks

A very simple Synology Package Server, reverse engineered from the official Synology package repository and SynoCommunity.
GNU General Public License v3.0
257 stars 64 forks source link

Improve tmp dir #30

Closed benrubson closed 7 years ago

benrubson commented 7 years ago

Hello,

System temp directory can sometimes not be writable by PHP. Users then have to use upload_tmp_dir.

This PR then selects upload_tmp_dir as the temp directory if it is set.

Thank you 👍

Ben

mbirth commented 7 years ago

Sorry, but this sounds more like a bad configuration. The temp dir should ALWAYS be writeable. Also, you can override the value returned by sys_get_temp_dir() in the php.ini.

And this is already checked by the selftest.php. So I don't think we need to mess with the uploads directory.

@jdel What do you think?

benrubson commented 7 years ago

Also, you can override the value returned by sys_get_temp_dir() in the php.ini.

You're right, as of PHP 5.5.0, we can set the sys_temp_dir INI setting. I was playing with an old 5.4 :) My mistake !

I then close this, thank you 👍