Allow empty maintainer and distributor

[benrubson]

Hello,

This PR allows to set empty maintainer and distributor in INFO file, so that this info is not displayed in Packet Center.

Thank you 👍

Ben

[jdel]

Could you read the values for

• maintainer
• maintainer_url
• distributor
• distributor_url

from the config file ?

[benrubson]

From the config file ? These values are taken from the INFO file, this PR allows for example to set in this file : maintainer="" So that this field won't be displayed in Packet Center.

However, if we don't set maintainer in INFO file, the default value SSpkS will be displayed.

[jdel]

I meant putting the default values in the configuration file. So if someone wants to change them they can just edit the config file

[benrubson]

Oh sorry, understood now :) JsonOutput does not know Config yet, not sure how to do it properly (without breaking files under tests/), but I could have a look deeper.

[benrubson]

OK, tests are failing, as I did not update them yet.

[mbirth]

Scrutinizer is still complaining. Could you fix the tests, too, please? (I think you can just give an empty Config object.)

[mbirth]

btw: You can run the checks locally by executing vendor/bin/phpunit from the project's root directory.

Do you know if the Synology can work with null values or does it need an empty string ("")?

[benrubson]

I tested with null values, Package Center works correctly, it simply does not show the values. Would you prefer an empty value ?

[mbirth]

Looking good now. I'm still waiting for @jdel 's green light to merge all your contributions. Many thanks for them!

[benrubson]

U're welcome, thank you for your great work 👍

[benrubson]

Do you know if the Synology can work with null values or does it need an empty string ("")?

Well, I finally faced (and reproduced) a case where Package Center was refreshing indefinitely with null values. Empty string solves this issue.