Invalid location with DSM 5.1-4977

cybfr commented 9 years ago

Thank you for this great package wich save me lot of reverse engineering time...

By the way with DSM 5.1-4977 the DSM does not accept my repo, invesigating a bit I saw tha DSM makes first a GET request with ds_sn=C7L1Nxxxxxx&unique=synology_qoriq_213%2B&language=fre&package_update_channel=beta&major=5&arch=qoriq&build=4977&timezone=Brussels&minor=1 and expect a json list of packages and then a POST with same data and still expecting a json list...

The following patch fix this :

diff --git a/index.php b/index.php index d18ca4b..d5d0c4d 100644 --- a/index.php +++ b/index.php @@ -22,16 +22,16 @@ $host = $_SERVER['HTTP_HOST'].substr($_SERVER['REQUEST_URI'], 0, strrpos($_SERVE

$siteName = "Simple SPK Server";

-if($_SERVER['REQUEST_METHOD'] == 'POST'){ +if(isset($_REQUEST['ds_sn'])){

$language = trim($_POST['language']);
$timezone = trim($_POST['timezone']);
$arch = trim($_POST['arch']);
$major = trim($_POST['major']);
$minor = trim($_POST['minor']);
$build = trim($_POST['build']);
$channel = trim($_POST['package_update_channel']);
$unique = trim($_POST['unique']);
$language = trim($_REQUEST['language']);
$timezone = trim($_REQUEST['timezone']);
$arch = trim($_REQUEST['arch']);
$major = trim($_REQUEST['major']);
$minor = trim($_REQUEST['minor']);
$build = trim($_REQUEST['build']);
$channel = trim($_REQUEST['package_update_channel']);
$unique = trim($_REQUEST['unique']);

if (!$language || !$timezone || !$arch || !$major || is_null($minor) || !$build || !$channel || !$unique || !$serial || !(preg_match("/^$unique/", $_SERVER['HTTP_USER_AGENT']) || $_SERVER['HTTP_USER_AGENT'] == "\"Mozilla/4.0 (compatible; MSIE 6.1; Windows XP) Synology\"" || $_SERVER['HTTP_USER_AGENT'] == "\"Mozilla/4.0 (compatible; MSIE 6.1; Windows XP)\"" )){ header('Content-type: text/html');

That said, there still a pb with the test on $serial, I needed to squeeze it (don't know where and how it's supposed to be initalized but is not...

Thanks & cheers

jdel commented 9 years ago

Thank you for reporting this. I will have a look at this as soon as I can but I have very little time at the moment.

jdel commented 9 years ago

Can you try to add http://packages.jdel.org/ to your DSM package sources ? I am using 5.1-4977 too but I'm not experiencing the issue you describe on my package repo.

cybfr commented 9 years ago

Le 07/11/2014 10:47, Julien Del-Piccolo a écrit :

Can you try to add http://packages.jdel.org/ to your DSM package sources ? I am using 5.1-4977 too but I'm not experiencing the issue you describe on my package repo.

Done and it works... Needs more investigations...

Thank's

François-Régis

jdel commented 9 years ago

Ok, so this repo uses the same index.php as the sspks package. It's just not hosted on a synology device. I will install SSPKS on my syno to see what happens.

jdel commented 9 years ago

I see that the final 5.1-5004 version is out now. You might want to try to upgrade your beta to this version too.

jdel commented 9 years ago

I installed the SSPKS package on my syno, and I added it to my sources with the URL: http://localhost/sspks/index.php

You need to specify /index.php at the end due to the syno apache config. For some reason, the beta doesn't default to index.php anymore.

cybfr commented 9 years ago

I didn't install SSPKS on a syno but on an hosted server which is in fact misconfigured (can't resolv hosts names)... I'm trying to see if this is the reason but I doubt...

Le 07/11/2014 11:05, Julien Del-Piccolo a écrit :

I installed the SSPKS package on my syno, and I added it to my sources with the URL: http://localhost/sspks/index.php

You need to specify /index.php at the end due to the syno apache config. For some reason, the beta doesn't default to index.php anymore.

— Reply to this email directly or view it on GitHub https://github.com/jdel/sspks/issues/8#issuecomment-62122020.

cybfr commented 9 years ago

Hi,

In fact :

I can add your repo but it does not show any of youre packages
The only point that blocked my index.php was the test on $serial (undefined => false). Just squeezing it do the trick.
My DSM send "synology_qoriq_213+ DSM5.1-4977 (package)" : [07/Nov/2014:14:31:26 +0100] "POST /sspks/ HTTP/1.1" 200 2138 "-" "synology_qoriq_213+ DSM5.1-4977 (package)"
My DSM first make a GET request : [07/Nov/2014:14:31:26 +0100] "GET /sspks/?ds_sn=C7Lxxxxxxx&unique=synology_qoriq_213%2B&language=fre&package_update_channel=beta&major=5&arch=qoriq&build=4977&timezone=Brussels&minor=1 HTTP/1.1" 200 2439 "-" "synology_qoriq_213+ DSM5.1-4977 (package)"

Chhers.

Le 07/11/2014 11:05, Julien Del-Piccolo a écrit :

I installed the SSPKS package on my syno, and I added it to my sources with the URL: http://localhost/sspks/index.php

You need to specify /index.php at the end due to the syno apache config. For some reason, the beta doesn't default to index.php anymore.

— Reply to this email directly or view it on GitHub https://github.com/jdel/sspks/issues/8#issuecomment-62122020.

Martijn085 commented 9 years ago

Any update on this? What i can see is that this is going wrong with the DS411+II with DSM 5.x if this one is running 4.x there is no problem.

jdel commented 9 years ago

Hi, sorry I never had any time to have a look at this issue just yet. I will try to do it over the week.

Martijn085 commented 9 years ago

Would be great, thanks!

Martijn085 commented 9 years ago

@jdel do you have any update on this?

colin1497 commented 9 years ago

I had the same issue, DSM 5.1-5022 Update 5. Removing the $serial test allowed it to work. Haven't pursued further...

mbirth commented 9 years ago

No worky in DSM 5.2-5592 Update 3. Can't add it as a package source due to Invalid location. error.

bipsendk commented 9 years ago

Found a way to get it working with 5.2-5592 update 2 ... My version now supports GPG key entry as well... Let me know if I should submit a diff file...

jdel commented 9 years ago

Sorry, never had time to look into the issue. @bipsendk, a pull request in github would be much appreciated.

bipsendk commented 9 years ago

@jdel - I tried to fork and do a pull request to edit index.php ... I don't know if I did it correct, as I'm not so familiar with the use of git...

Let me know whether you can see my changes or not....

I am having an issue with my package icon not being displayed under "Community" packages in the package manager - even though the json output specifies the path to a couple of thumbnails.. I am still investigating on this issue...

mbirth commented 7 years ago

Any news here or can this be closed?

jdel commented 7 years ago

I think this can be closed, the initial patch proposed is impossible to apply.

Please use the latest version of SSPKS and reopen an issue if the problem persists.

jdel / sspks

Invalid location with DSM 5.1-4977 #8