jdeng / goheif

go gettable decoder/converter for HEIF/HEIC based on libde265
179 stars 67 forks source link

error in mac-os, can't build #6

Closed xoba closed 14 hours ago

xoba commented 5 years ago

here's the log i see:

iCloud Photos$ go get github.com/jdeng/goheif/...
# github.com/jdeng/goheif/libde265
In file included from libde265.cc:2:
In file included from src/github.com/jdeng/goheif/libde265/libde265-all.inl:37:
src/github.com/jdeng/goheif/libde265/libde265/slice.cc:2447:9: warning: 'MAX_PREFIX' macro redefined [-Wmacro-redefined]
src/github.com/jdeng/goheif/libde265/libde265/cabac.cc:419:9: note: previous definition is here
# github.com/jdeng/goheif/heic2jpg
src/github.com/jdeng/goheif/heic2jpg/main.go:80:14: undefined: goheif.DecodeImage
iCloud Photos$ 
mikegleasonjr commented 5 years ago

DecodeImage has been renamed to Decode a while back to follow the Go convention:

Offending line:

https://github.com/jdeng/goheif/blob/master/heic2jpg/main.go#L80