search

jdepoix / youtube-transcript-api

This is a python API which allows you to get the transcript/subtitles for a given YouTube video. It also works for automatically generated subtitles and it does not require an API key nor a headless browser, like other selenium based solutions do!
MIT License
2.87k stars 326 forks source link

Assert types #154

Closed majamil16 closed 1 year ago

majamil16 commented 2 years ago

Added an assert statement in get_transcripts / get_transcript to check if input is of the expected type - closes #125

jdepoix commented 2 years ago

Hi @majamil16, thank you very much for your contribution! I have been postponing this for forever, so this is very much appreciated! 😊 👍

However, for some reason the travis builds are not triggered automatically. I just did a quick check and couldn't figure out why, so I will have to put in a bit more time to get this fixed before being able to merge this.

majamil16 commented 2 years ago

@jdepoix sure thing! Let me know if there's anything I can help with.

jdepoix commented 1 year ago

Hi @majamil16, sorry for the late merge. I have been really busy lately and forgot about this PR still being open to be honest 🙈 I fixed the builds and merged it now. I expect another PR to be merged soon and will release them together in v0.5.0. Thank you very much for your contribution! 😊 👍

jdepoix commented 1 year ago

Released in v0.5.0! 🥳 Thank you very much for you contribution @majamil16 ! 😊