search

jdepoix / youtube-transcript-api

This is a python API which allows you to get the transcript/subtitles for a given YouTube video. It also works for automatically generated subtitles and it does not require an API key nor a headless browser, like other selenium based solutions do!
MIT License
2.87k stars 326 forks source link

added new Formatter for SRT files #164

Closed liamrs222 closed 1 year ago

liamrs222 commented 2 years ago

New feature based on issue #162 The user can import the subclass SRTFormatter to get the string format for SRT files:

from youtube_transcript_api.formatters import SRTFormatter

SRT

liamrs222 commented 2 years ago

Hello, this is my first contribution to open source, so I wanted to try submitting a pull request. Let me know if there are any issues!

liamrs222 commented 1 year ago

Thank you for the feedback! I will work on these issues.

jdepoix commented 1 year ago

Thank you for the feedback! I will work on these issues.

No worries, let me know if there's anything you need assistance with! 😊

liamrs222 commented 1 year ago

I added some tests to bring coverage back to 100%, but let me know if I can improve the tests

jdepoix commented 1 year ago

I added some tests to bring coverage back to 100%, but let me know if I can improve the tests

Thank you very much! There's just a small detail I would want to change about the tests (see my other comment). I will merge this and release v0.5.0, once you fixed those! 👍

liamrs222 commented 1 year ago

Thank you very much! There's just a small detail I would want to change about the tests (see my other comment). I will merge this and release v0.5.0, once you fixed those! 👍

Thanks for all your help with this pull request! I made those changes you suggested.

jdepoix commented 1 year ago

Released in v0.5.0! 🥳 Thank you very much for you contribution @liamrs222 ! 😊