search

jdesrosiers / silex-cors-provider

A silex service provider that adds CORS services to silex
MIT License
78 stars 25 forks source link

Add support for specifying the Access-Control-Allow-Headers CORS header #2

Closed jdesrosiers closed 7 years ago

jdesrosiers commented 11 years ago

As far as I know, the CorsServiceProvider can support all features in the CORS specification except one Access-Control-Allow-Headers. It cheats by hardcoding this header *. For this service to be complete, it needs to all the user to specify a value for Access-Control-Allow-Headers.

bobeagan commented 10 years ago

Is this still true?

jdesrosiers commented 10 years ago

Yes. I have not implemented support for setting the Access-Control-Allow-Headers header. I have never needed to use this feature and have had no requests for it, so I don't plan on implementing it any time soon. I've kept the issue open in case anyone wants to request the feature be implemented or submit a pull request.

Is this a feature you would like to have?

bobeagan commented 10 years ago

I don't need it right this moment but I'd see it as a nice-to-have so that the spec was fully implemented.

jdesrosiers commented 10 years ago

That's exactly what I was thinking when I created the issue in the first place :)

herbertpimentel commented 8 years ago

+1 I also need that.

jdesrosiers commented 8 years ago

@herbertpimentel, I'll look into it, but it will be at least a few weeks before I have the time.

jdesrosiers commented 7 years ago

It's been a while, but I finally went back and added this functionality.