Having HTTP 405 Method not allowed response when used with annotations

jdesrosiers / silex-cors-provider

A silex service provider that adds CORS services to silex

MIT License

78 stars 25 forks source link

Having HTTP 405 Method not allowed response when used with annotations #33

Closed alcalyn closed 7 years ago

alcalyn commented 7 years ago

I'm trying to make a PUT HTTP request:

The browser then send the preflight request:

Request:

OPTIONS /index-dev.php/api/teams/4/users/32 HTTP/1.1
Host: localhost:20000
Access-Control-Request-Method: PUT
origin: http://localhost
Connection: keep-alive

Response:

HTTP/1.1 405 Method Not Allowed
Server: nginx/1.11.8
Connection: keep-alive
Allow: PUT
Access-Control-Allow-Methods: PUT
Access-Control-Allow-Origin: http://localhost

I can see the cors headers are well set, but it keeps the 405 status code and the silex error page in body which is saying that the OPTIONS method is not allowed for this controller.

I don't want to make all my controllers match the OPTIONS method.

I can see that the cors servcie does its jobs, it adds cors headers on response, but on the same response which is actually the error response.

alcalyn commented 7 years ago

So adding the snippet code I posted in the related issue, it fixes the thing, even if it does it on any request, I think I can adapt the snippet to make it work correctly.

But I think the logic is to send a new response before running the controller instead of using the response from the controller, add cors headers and sending it with the wrong status code and body.

alcalyn commented 7 years ago

In fact this happens on controllers registered with annotations: https://github.com/danadesrosiers/silex-annotation-provider

Not working:

use DDesrosiers\SilexAnnotations\Annotations as SLX;

/**
 * @SLX\Route(
 *      @SLX\Request(method="PUT", uri="/api/my-route")
 * )
 */
public function addUser()
{
    // ...
}

Working:

$this['app.controller.my'] = function () {
    return new \App\Controller\MyController();
};

$this->put('/api/my-route', 'app.controller.my:addUser');