search

jdesrosiers / silex-swagger-provider

A silex service provider that integrates swagger-php into silex
MIT License
21 stars 10 forks source link

Unit tests fail with zircote/swagger-php >= 0.8.2 #5

Closed andreiashu closed 10 years ago

andreiashu commented 10 years ago

https://github.com/zircote/swagger-php/compare/0.8.1...0.8.2

And that's because of this change:

## 0.8.2

Extract descriptions from the docblock for model, resources, properties and apis. furter reducing duplicate descriptions.
 Fixes issues: #115 & #116
jdesrosiers commented 10 years ago

Thanks. I'll have it fixed by tomorrow.

andreiashu commented 10 years ago

Hi, Unfortunately there's still a failed test on swagger-php 0.9.0:

There was 1 failure:

1) JDesrosiers\Tests\Silex\Provider\SwaggerServiceProviderTest::testLogging Expectation failed for method name is equal to string:notice when invoked 1 time(s). Method was expected to be called 1 times, actually called 2 times.

BTW: I believe the v0.1.2 tag is not from latest master, hence travis build still passed: https://github.com/jdesrosiers/silex-swagger-provider/compare/v0.1.2

jdesrosiers commented 10 years ago

The test is passing for me locally and on travis last night. I am sure it tested and passed both master and the unrelated tag to the 0.x version. I suspect an environment difference. I could relax the test constraints. It doesn't really matter how many times this method is call. That might solve the problem.

jdesrosiers commented 10 years ago

I made a slight modification and the results appear to be consistent now.