jdev082 / freecat

The FreeCat Web Browser
Other
5 stars 5 forks source link

Disallow prettier using gitignore #109

Closed hello-smile6 closed 2 years ago

hello-smile6 commented 2 years ago

I'll try to make a workflow which checks package.json for Prettier and fails if it finds it.

jdev082 commented 2 years ago

Your PR will be reviewed over the next 24 hours. Please continue to thoroughly test your code.

jdev082 commented 2 years ago

I'll try to make a workflow which checks package.json for Prettier and fails if it finds it.

this isn't needed nobody will try to use it

however a workflow that checks for syntax errors, thats whats needed. eslint has an option to ONLY check syntax errors instead of styling which breaks everything

jdev082 commented 2 years ago

I'll try to make a workflow which checks package.json for Prettier and fails if it finds it.

this isn't needed nobody will try to use it

however a workflow that checks for syntax errors, thats whats needed. eslint has an option to ONLY check syntax errors instead of styling which breaks everything

have eslint not auto fix errors, just LIST them in the PR comments

hello-smile6 commented 2 years ago

I'll try to make a workflow which checks package.json for Prettier and fails if it finds it.

this isn't needed nobody will try to use it however a workflow that checks for syntax errors, thats whats needed. eslint has an option to ONLY check syntax errors instead of styling which breaks everything

have eslint not auto fix errors, just LIST them in the PR comments

Don't know how to do that.

jdev082 commented 2 years ago

I'll try to make a workflow which checks package.json for Prettier and fails if it finds it.

this isn't needed nobody will try to use it however a workflow that checks for syntax errors, thats whats needed. eslint has an option to ONLY check syntax errors instead of styling which breaks everything

have eslint not auto fix errors, just LIST them in the PR comments

Don't know how to do that.

Nobody needs eslint if you didn't break this so often