search

jdev082 / freecat

The FreeCat Web Browser
Other
5 stars 5 forks source link

Remove rickroll #39

Closed hello-smile6 closed 2 years ago

hello-smile6 commented 2 years ago

Sorry, I'll make a pull request to fix it on every fork. This PR also updates dependencies in package-lock.json (no breaking changes).

hello-smile6 commented 2 years ago

@JaydenDev Could you merge this?

webdev03 commented 2 years ago

I think this is a sign that we should always review what code goes into our projects - you know, what if someone put a keylogger instead?

hello-smile6 commented 2 years ago

I think this is a sign that we should always review what code goes into our projects - you know, what if someone put a keylogger instead?

I agree. I was mainly hoping it wouldn't get merged. I noticed that my previous PRs were merged without much (or any, in fact) review.

webdev03 commented 2 years ago

@JaydenDev please merge to avoid rick astley

hello-smile6 commented 2 years ago

@JaydenDev please merge to avoid rick astley

I've already made PRs to fix this for @Polygon , just make PRs for everyone else.

jdev082 commented 2 years ago

don't be silly with PRs.

hello-smile6 commented 2 years ago

don't be silly with PRs.

I really did add a rickroll! This removes it.

webdev03 commented 2 years ago

No @JaydenDev We are being serious, PLEASE REVIEW THE PR, see there is actually a rickroll that overrides native keybinds.

webdev03 commented 2 years ago

No need to merge now, I did in my PR I think